ci: add job to verify simple GHA workflow#4112
Open
bluca wants to merge 1 commit intosystemd:mainfrom
Open
Conversation
systemd@e276dac introduced a regression that broke using the mkosi action in a simple workflow that builds and boots an image. Add a new job that provides such a smoke test, to avoid these regressions
Contributor
|
This looks like a good addition, but couldn't we add just the smoke test in the integration test and skip building an additional image? In the grand scheme of things it probably doesn't matter, since we're building so many already. |
Member
Author
|
I thought about that, but the goal here was to try and replicate a simple enough workflow file one might use in another repo to avoid such regressions, having it mixed with the complex and custom existing one risks masking some issues |
Contributor
|
I would like to figure out why this one triggers the issue and the other ones don't tbh before we merge this. |
Member
Author
|
Wasn't it sudo? |
Member
Author
|
Can we merge this please? I'd like to avoid further regressions sneaking in - having an extra couple of CI jobs shouldn't hurt, they are fairly quick anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e276dac introduced a regression that broke using the mkosi action in a simple workflow that builds and boots an image.
Add a new job that provides such a smoke test, to avoid these regressions